[PATCH] D56969: GlobalISel: Fix widenScalarToNextPow2 mutation for vectors

[Amara Emerson via Phabricator via llvm-commits]

aemerson added a comment.

In D56969#1376445 <https://reviews.llvm.org/D56969#1376445>, @volkan wrote:

> In D56969#1376243 <https://reviews.llvm.org/D56969#1376243>, @arsenm wrote:
>
> > In D56969#1373222 <https://reviews.llvm.org/D56969#1373222>, @aemerson wrote:
> >
> > > My preference here would be to have a separate set of mutations for vector elements, @dsanders @aditya_nandakumar what do you think?
> >
> >
> > What about having 3 versions for each of these? e.g. minScalar, minElement, minScalarOrElement?
>
>
> I don't think we need separate mutations to do the same thing. I would prefer using widenScalarToNextPow2, but we should rename it to make it clear. Maybe something like widenScalarOrElementToNextPow2?
>
> @aemerson @arsenm, what do you think?


That's ok with me, maybe shorten it a bit to widenScalarOrEltToNextPow2.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56969/new/

https://reviews.llvm.org/D56969