[PATCH] D57436: gn build: Add BPF target.

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 30 13:12:13 PST 2019


thakis added a comment.

In D57436#1377680 <https://reviews.llvm.org/D57436#1377680>, @ast wrote:

> hmm. so you're saying when we add new file to the normal CMakeFiles, we don't need to touch GN ?


Yes.

> So it's going to bit rot immediately?

No – turns out files aren't changed that frequently, and people who use the GN build usually fix up the build files pretty quickly. (`git log --pretty=oneline --grep Merge llvm/utils/gn/`)

> what's the purpose of this GN work then?

gn runs 1000x faster than cmake, and it allows things like https://reviews.llvm.org/D56713 . It also has the effect of us reading the cmake files very closely and cleaning them up a bit :-)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57436/new/

https://reviews.llvm.org/D57436





More information about the llvm-commits mailing list