[PATCH] D57436: gn build: Add BPF target.

Yonghong Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 30 13:03:55 PST 2019


yonghong-song added a comment.

I read through the link and yes the code looks okay. I think this is a communication issue.
It would be good next time if you have better commit messages which provides enough info. about the change so reviewers can at least
take a look knowing what happens. In the case the reviewer requested a change, it would be good to send out information (as you did)
and wait for acknowledgement before merging.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57436/new/

https://reviews.llvm.org/D57436





More information about the llvm-commits mailing list