[PATCH] D57377: [CGP] Add support for sinking operands to their users, if they are free.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 30 12:06:56 PST 2019


fhahn marked 2 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:5984
+
+  // OpsToSink can contain multiple uses in a use chain (e.g.
+  // (%u1 with %u1 = shufflevector), (%u2 with %u2 = zext %u1)). The dominating
----------------
samparker wrote:
> Is this order of ops enforced?
Do you mean enforced as in by an assertion? Not at the moment. I think we would could check it with OrderedInstructions, if you think it would be beneficial.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57377/new/

https://reviews.llvm.org/D57377





More information about the llvm-commits mailing list