[PATCH] D56947: [WebAssembly] Fix crash with LTO + relocatable + undefined symbols

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 30 10:49:17 PST 2019


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: wasm/Writer.cpp:907
 
-        SectionSymbolIndices[Name] = SymbolIndex;
-        CustomSectionSymbols[Name] = cast<SectionSymbol>(Sym);
+  auto AddSymbol = [&](Symbol* Sym) {
+    if (auto *S = dyn_cast<SectionSymbol>(Sym)) {
----------------
`Symbol*` -> `Symbol *`


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56947/new/

https://reviews.llvm.org/D56947





More information about the llvm-commits mailing list