[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Kamil,

I understand how adding `--target` option to the linker would make target-specific customization easier, but that's as I said not acceptable by design in lld. The code we have for FreeBSD just sets one bit in the output file, and that's fundamentally different from adding a "master switch" to turn on all customization for some specific target. We've been making changes to lld to make it work for many targets, but the features we've added are on by default (such as the code for Android TLS layout or supporting `.openbsd.randomdata` section for OpenBSD) or enabled by per-feature basis by a command line flag (such as *-freebsd emulation name). There's no flag like "turning lld into FreeBSD mode" or something like that. It seems to be working pretty well, and I'm happy about that design. So, I'm sorry, but I don't think I can support this patch's approach at all.

Honestly what's special about NetBSD from the lld's perspective seems to be the code ownership of the compiler driver. I can help you solve technical issues, but I don't think I should accept a patch that's against one of the lld's fundamental design choices to solve non-technical problems.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56650/new/

https://reviews.llvm.org/D56650