[PATCH] D57385: [ELF] Support --{,no-}allow-shlib-undefined

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Writer.cpp:1704
+        auto *File = dyn_cast_or_null<SharedFile<ELFT>>(Sym->File);
+        if (File && AllNeededIsKnown.count(File))
+          error(File->getName() + ": undefined reference to " + toString(*Sym));
----------------
Isn't looking up a hash table for each symbol too slow? Maybe you should add a bit to SharedFile?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57385/new/

https://reviews.llvm.org/D57385