[PATCH] D57449: GlobalISel: Add alignment to LegalityQuery MMOs

Petar Avramovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 30 07:36:54 PST 2019


Petar.Avramovic added a comment.

Hi, this rule will be very useful for mips32r5 that only supports naturally aligned loads and stores. 
However, could we have additional structure named TypeMemAndAlignDesc (or something more appropriate) and rule that uses this structure named legalForTypesWithMemSizeAndAlign instead of changing already existing ones.
This would leave TypePairAndMemSize and typePairAndMemSizeInSet to be used as is, since alignment is not considered on some targets/subtargets (like mips32r6). There are rules that do not take memsize into account (like LegalFor or legalForCartesianProduct).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57449/new/

https://reviews.llvm.org/D57449





More information about the llvm-commits mailing list