[PATCH] D56329: Fix some warnings on MSVC

Wed Jan 30 07:32:23 PST 2019

chrisjackson added a comment.

Hi @aganea ,

With regards to

  93 if( CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 19.15 )

I believe

  VERSION_GREATER_EQUAL

requires CMake version 3.7, see the CMake 3.7 release notes <https://cmake.org/cmake/help/v3.7/release/3.7.html#commands>.

The LLVM documents <https://llvm.org/docs/CMake.html> and //llvm/CmakeLists.txt// list the minimum required CMake version for LLVM as 3.4.3. I believe that the minimum CMake version should be updated or an alternative method for checking the compiler version should be used.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56329/new/

https://reviews.llvm.org/D56329