[PATCH] D57248: [llvm-objcopy] Support -X|--discard-locals.

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 30 06:28:45 PST 2019


rupprecht marked an inline comment as done.
rupprecht added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/StripOpts.td:61
+def discard_locals : Flag<["-", "--"], "discard-locals">,
+                     HelpText<"Remove compiler-generated local symbols, (e.g. "
+                              "symbols starting with .L)">;
----------------
jhenderson wrote:
> Perhaps this should be "i.e." rather than "e.g."?
I think `.L` is not universal -- it seems macho and (sometimes) COFF uses just L, and mips uses $ -- hence "e.g." as this is just ELF's example.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57248/new/

https://reviews.llvm.org/D57248





More information about the llvm-commits mailing list