[PATCH] D57446: [llvm-symbolizer][test] Extract tests from llvm-symbolizer.test and simplify (#2)

[James Henderson via Phabricator via llvm-commits]

jhenderson created this revision.
jhenderson added reviewers: dblaikie, ruiu, MaskRay.
Herald added subscribers: rupprecht, erik.pilkington.

This is the third of a series of patches relating to simplifying llvm-symbolizer tests. See D57441 <https://reviews.llvm.org/D57441> and D57443 <https://reviews.llvm.org/D57443> for the previous two. In this one, I have split out a number of distinct test cases from the llvm-symbolizer.test test into separate tests, and simplified them in various ways including:

1. by using --obj/positional arguments for the input file and addresses instead of stdin,
2. using runtime-generated inputs rather than a pre-canned binary, and
3. testing more specifically (i.e. checking only what is interesting to the behaviour changed in the original commit for that test case).

I've removed the test case for using --obj. The tools/llvm-symbolizer/basic.s already tests this case. I've also added a simple test case to the demangle switch test case to show that demangling happens by default.

See PR40070 comment 1 onwards for the motivation.


Repository:
  rL LLVM

https://reviews.llvm.org/D57446

Files:
  test/DebugInfo/Inputs/llvm-symbolizer-test.c
  test/DebugInfo/Inputs/llvm-symbolizer-test.elf-x86-64
  test/DebugInfo/llvm-symbolizer.test
  test/DebugInfo/symbolize-demangling.s
  test/DebugInfo/symbolize-macho-universal-unknown-arch.test
  test/DebugInfo/symbolize-macho-universal.test
  test/tools/llvm-symbolizer/demangle.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57446.184276.patch
Type: text/x-patch
Size: 7425 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190130/d6b82a1e/attachment.bin>