[PATCH] D57327: [ARM] Thumb2: ConstantMaterializationCost

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 30 02:52:39 PST 2019


SjoerdMeijer updated this revision to Diff 184260.
SjoerdMeijer added a comment.

> Maybe put the tests into test/CodeGen/ARM/subtarget-no-movt.ll? We have some similar tests there from https://reviews.llvm.org/D23090 .

Ah, sorry, somehow I missed that comment.

- The test cases have been moved to `test/CodeGen/ARM/subtarget-no-movt.ll`, and
- while I was at it, cleaned up the duplicated mess that was this file (and it also included a typo  USE-MOVTT-O0 resulting in FileCheck not checking that line, one day I would really like to change FileCheck so that it errors for these cases...)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57327/new/

https://reviews.llvm.org/D57327

Files:
  lib/Target/ARM/ARMISelDAGToDAG.cpp
  test/CodeGen/ARM/subtarget-no-movt.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57327.184260.patch
Type: text/x-patch
Size: 7004 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190130/d3b72b2d/attachment.bin>


More information about the llvm-commits mailing list