[PATCH] D57441: [llvm-symbolizer][test] Simplify test input reading

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 30 02:52:39 PST 2019


jhenderson created this revision.
jhenderson added reviewers: dblaikie, ruiu, MaskRay.
Herald added subscribers: rupprecht, kbarton, nemanjai.

This change migrates most llvm-symbolizer tests away from reading input via stdin and instead using --obj + positional arguments for the file and addresses respectively, which makes the test easier to read.

One exception is the test test/tools/llvm-symbolizer/pdb/pdb.test, which was doing some manipulation on the input addresses. I've simplified this somewhat, but it still reads from stdin.

More changes to follow to simplify/break-up other tests.


Repository:
  rL LLVM

https://reviews.llvm.org/D57441

Files:
  test/DebugInfo/llvm-symbolizer-split-dwarf-no-skel-address.test
  test/DebugInfo/llvm-symbolizer-tu.test
  test/DebugInfo/llvm-symbolizer-zlib.test
  test/tools/llvm-symbolizer/coff-dwarf.test
  test/tools/llvm-symbolizer/coff-exports.test
  test/tools/llvm-symbolizer/fat.test
  test/tools/llvm-symbolizer/padding-x86_64.ll
  test/tools/llvm-symbolizer/pdb/missing_pdb.test
  test/tools/llvm-symbolizer/pdb/pdb.test
  test/tools/llvm-symbolizer/ppc64.test
  test/tools/llvm-symbolizer/print_context.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57441.184264.patch
Type: text/x-patch
Size: 10414 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190130/ce697bf3/attachment.bin>


More information about the llvm-commits mailing list