[PATCH] D57423: [llvm-objcopy][NFC] More error propagation
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 30 01:33:28 PST 2019
jhenderson added inline comments.
================
Comment at: llvm/tools/llvm-objcopy/llvm-objcopy.cpp:147-148
-static void executeObjcopyOnArchive(const CopyConfig &Config,
- const Archive &Ar) {
+static Error executeObjcopyOnArchive(const CopyConfig &Config,
+ const Archive &Ar) {
std::vector<NewArchiveMember> NewArchiveMembers;
----------------
You seem to have missed several `reportError` calls in this function. Was that intentional?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57423/new/
https://reviews.llvm.org/D57423
More information about the llvm-commits
mailing list