[PATCH] D53765: [RFC prototype] Implementation of asm-goto support in LLVM

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 29 16:14:12 PST 2019


efriedma added a comment.

> I'm not sure what we do for indirect branches, but I suspect analyzeBranch returning unanalyzable for indirect jumps is part of it. But that doesn't work for asm goto because our terminator is a direct jump which is analyzable.

Did you consider making blocks which contain an asm goto unanalyzable?  Intuitively, that's what I would expect given an asm goto is a terminator at the IR level.  But I guess that makes handling the fallthrough case efficiently more difficult?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53765/new/

https://reviews.llvm.org/D53765





More information about the llvm-commits mailing list