[PATCH] D57398: SimplifyDemandedVectorElts for all intrinsics

Tue Jan 29 14:27:05 PST 2019

reames planned changes to this revision.
reames added a comment.

In D57398#1376055 <https://reviews.llvm.org/D57398#1376055>, @RKSimon wrote:

> Any insight into why those tests have changed?

Thank you for pushing on this.  While trying to find an answer to your question, I found a bug in the patch.

The answer is that x86_avx512_mask_mul_sd_round and friends have the order of operation changed on two transforms.  Previously, we did their dedicated transform, then fell through into the code I removed.  Now, we simplify via demanded elements first, then process them via dedicated transforms.

That fallthrough is where the bug is though.  We're now falling through into the wrong handler.  The fallthrough needs replaced w/a break.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57398/new/

https://reviews.llvm.org/D57398