[PATCH] D57412: [scudo] Initial standalone skeleton check-in

Kamil Rytarowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 29 14:22:32 PST 2019


krytarowski added a comment.

In D57412#1376056 <https://reviews.llvm.org/D57412#1376056>, @cryptoad wrote:

> In D57412#1376046 <https://reviews.llvm.org/D57412#1376046>, @krytarowski wrote:
>
> > I have got a scudo support patch for NetBSD locally.. but the original tests are havily prepared against GNU malloc. This makes me uncertain whether scudo really works. Are there plans to make the tests more generic?
>
>
> That should be the case for the unit-tests. The new way things are done will clearly separate the C/C++ wrappers.
>  I can add you on the standalone check-ins for you to chime in on the direction we are headed to.
>  All the development efforts so far has targeted Linux/Android/Fuchsia, and I unfortunately have no BSD knowledge, but we are definitely open to contributions.
>  Initial check-ins will be Linux specific though since it's my workstation and that's what I am testing things against.
>
> I wouldn't pursue work on your side on the current non-standalone Scudo, as the standalone version will be better (more performant, smaller memory footprint, etc) on all fronts.


Please keep tests agnostic to system malloc implementation (as much as possible). I will rebase or rework my NetBSD support code and upstream. When I did the port I was unsure whether it even works, but the situation maybe improved since the introduction of Fuchsia.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57412/new/

https://reviews.llvm.org/D57412





More information about the llvm-commits mailing list