[PATCH] D57324: lld/coff: Implement some support for the comdat selection field

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: lld/COFF/InputFiles.cpp:508
+          error(Msg);
+      }
+
----------------
ruiu wrote:
> Is it safe to fall through? Maybe you want to do `continue` to skip it.
At least for the warn() case I figured it's probably better to link in the comdat with the new Selection value.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57324/new/

https://reviews.llvm.org/D57324