[PATCH] D57370: [WebAssembly] Don't load weak undefined symbols from archive files

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: wasm/Driver.cpp:314
+
+    if (!Sig)
       continue;
----------------
Is this the same as `isa<FunctionSYmbol>(Sym) || isa<LazySymbol>(Sym)`? Looks like `Sig` can be nullptr if Lazy, but I don't understand what's that case.


================
Comment at: wasm/SymbolTable.cpp:396
+    // signature.
+    if (auto* F = dyn_cast<UndefinedFunction>(S))
+      OldSig = F->Signature;
----------------
`auto*` -> `auto *`


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57370/new/

https://reviews.llvm.org/D57370