[PATCH] D57264: Bump minimum toolchain version

Tue Jan 29 10:58:13 PST 2019

jfb added subscribers: itaraban, vitalybuka, colinl, kparzysz, gkistanova, rnk.
jfb added a comment.

In D57264#1374934 <https://reviews.llvm.org/D57264#1374934>, @jyknight wrote:

> In D57264#1374659 <https://reviews.llvm.org/D57264#1374659>, @jfb wrote:
>
> > @jyknight can you confirm that this latest change works for you? I think it's exactly your environment :)
>
>
> Well, the environment in question doesn't actually use CMake, so this change won't affect it.

Ah right!

In D57264#1374902 <https://reviews.llvm.org/D57264#1374902>, @jyknight wrote:

> In D57264#1374606 <https://reviews.llvm.org/D57264#1374606>, @jfb wrote:
>
> > In D57264#1374596 <https://reviews.llvm.org/D57264#1374596>, @jyknight wrote:
> >
> > > OK, let's do it.
> > >
> > > But better watch the buildbots to see if any get broken by the new requirements (hopefully we have at least one that will be?), and add the extra_cmake_args as needed.
> >
> >
> > You mean: pass a cmake argument so the buildbots don't fail? That would seem to defeat the purpose, no?
>
>
> We need to be aware of which of the llvm project's official buildbots need upgrading. If any are broken, ISTM that the best thing to do is to mark each such individual bot that needs to be upgraded by setting the the LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN cmake argument in the buildbot configuration, to allow them to continue to build. Then, we know where things stand, and over the next month, the owners can upgrade as necessary, without it being an emergency.
>
> Well, really, we should probably have at least one bot using the old version intentionally (assuming there are any now), so we can continue testing it until it's desupported.
>
> The other options -- leaving bots broken (and unable to test any other changes) until someone can get around to upgrading it, or reverting this commit until all bots all been upgraded -- seem strictly worse.

Maybe I'm missing something obvious... do we have a buildbot configuration? I just looked at some bots and I see them running cmake with e.g.:

  cmake -DCMAKE_BUILD_TYPE=Release -DLLVM_BUILD_TESTS=ON -DLLVM_ENABLE_ASSERTIONS=OFF -DLLVM_OPTIMIZED_TABLEGEN=ON -DCLANG_BUILD_EXAMPLES=OFF -GNinja -DLLVM_ENABLE_WERROR=OFF -DCMAKE_INSTALL_PREFIX=../../install/stage1 '-DLLVM_LIT_ARGS="-v"' ../../llvm

or

  cmake -GNinja '-DLLVM_ENABLE_PROJECTS=clang;lld' '-DLLVM_ENABLE_RUNTIMES=compiler-rt;libcxx;libcxxabi;libunwind' -DBOOTSTRAP_LLVM_ENABLE_LTO=OFF -DLLVM_ENABLE_LTO=OFF -DCMAKE_INSTALL_PREFIX=/b/fuchsia-x86_64-linux/llvm.install -DFUCHSIA_SDK=/b/fuchsia-x86_64-linux/fuchsia.sdk -C../llvm.src/clang/cmake/caches/Fuchsia.cmake -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_WERROR=ON -DLLVM_OPTIMIZED_TABLEGEN=ON ../llvm.src/llvm

To speed things up I just audited *all* bots in http://lab.llvm.org:8011/buildslaves (there's so many!). Some of them are down, I therefore have no idea what they run. Here are the bots that will definitely break, with their maintainers:

> Galina Kistanova <gkistanova at gmail.com> @gkistanova 
>  am1i-slv1 -- gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4
>  as-bldslv4 -- Microsoft (R) Visual Studio (R) 2015 (14.0)
>  ps4-buildslave2 -- Microsoft (R) Visual Studio (R) 2015 (14.0)
> 
> Hexagon QA <llvm.buildmaster at quicinc.com> @kparzysz @colinl
>  hexagon-build-02 -- gcc (Ubuntu 4.9.2-10ubuntu13) 4.9.2
>  hexagon-build-03 -- gcc (Ubuntu 4.9.2-10ubuntu13) 4.9.2
> 
> Vitaly Buka <vitalybuka at google.com> @vitalybuka 
>  sanitizer-buildbot6 -- gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4
> 
> Reid Kleckner <rnk at google.com> @rnk 
>  sanitizer-windows -- Microsoft (R) Visual Studio (R) 2015 (14.0)
> 
> Ilia Taraban <mstester.llvm at gmail.com> @itaraban 
>  windows7-buildbot -- Microsoft (R) Visual Studio (R) 2015 (14.0)

To expedite things I've tagged them above, and Im going to email them individually so that they either pass `LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN ` to their bots, update the bot to a newer compiler version, or entirely turn down their bot.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57264/new/

https://reviews.llvm.org/D57264