[PATCH] D57399: AMDGPU/GlobalISel: Add support for wide loads >= 256-bits

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp:451-454
+      MachineMemOperand *SplitMMO = B.getMF().getMachineMemOperand(
+          MMO.getPointerInfo().getWithOffset(OffsetBytes), MMO.getFlags(),
+          MaxNonSmrdLoadSize / 8, Alignment, MMO.getAAInfo(), MMO.getRanges(),
+          MMO.getSyncScopeID(), MMO.getOrdering(), MMO.getFailureOrdering());
----------------
arsenm wrote:
> You can do just MF.getMachineMemOperand(MMO, Offset, Size). I hit a bug in it though for D57122
Actually for this entire part I think once my other load/store patches are committed, you could just re-use the functions in LegalizerHelper


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57399/new/

https://reviews.llvm.org/D57399