[PATCH] D56781: Use response file when generating LLVM-C.dll

[Stella Stamenova via Phabricator via llvm-commits]

stella.stamenova requested changes to this revision.
stella.stamenova added inline comments.
This revision now requires changes to proceed.


================
Comment at: tools/llvm-shlib/CMakeLists.txt:136
+  # Set this name here and touch up if needed.
+  set(LIBSFILE ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/libllvm-c.args)
+
----------------
Maybe there's something wrong with my view of this change, but the way I am seeing it, tools/llvm-shlib/CMakeLists.txt appears twice and one of the versions has LIBSFILE and the other one doesn't anymore.

The way LIBSFILE is defined, it still depends on CMAKE_CFG_INTDIR, so this won't work on Windows with VS.

Could you check whether you see the change the same way (with two tools/llvm-shlib/CMakeLists.txt) and update it, so that it's clear what the final change is? 


================
Comment at: tools/llvm-shlib/CMakeLists.txt:138
+
+  if(NOT "${CMAKE_CFG_INTDIR}" STREQUAL ".")
+    foreach(BUILD_MODE ${CMAKE_CONFIGURATION_TYPES})
----------------
There lots of duplication between the two cases, I think you can simplify this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56781/new/

https://reviews.llvm.org/D56781