[PATCH] D57395: [ThinLTO] Rename COMDATs for COFF when promoting/renaming COMDAT leader

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 29 09:46:05 PST 2019


tejohnson created this revision.
tejohnson added reviewers: pcc, inglorion.
Herald added subscribers: dexonsmith, mehdi_amini.

COFF requires that COMDAT name match that of the leader. When we promote
and rename an internal leader in ThinLTO due to an import, ensure we
subsequently rename the associated COMDAT. Similar to D31963 <https://reviews.llvm.org/D31963> which did
this during ThinLTO module splitting.

Fixes PR40414.


Repository:
  rL LLVM

https://reviews.llvm.org/D57395

Files:
  include/llvm/Transforms/Utils/FunctionImportUtils.h
  lib/Transforms/Utils/FunctionImportUtils.cpp
  test/Transforms/FunctionImport/Inputs/comdat.ll
  test/Transforms/FunctionImport/comdat.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57395.184113.patch
Type: text/x-patch
Size: 4253 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190129/5994c2f6/attachment.bin>


More information about the llvm-commits mailing list