[PATCH] D57271: [DebugInfo] Handle restore instructions in LiveDebugValues

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: include/llvm/CodeGen/MachineInstr.h:1403
+  /// Return a valid size if the instruction is a spill instruction.
+  Optional<unsigned> isSpillInstruction(const TargetInstrInfo *TII) const;
+
----------------
aprantl wrote:
> Might be better to call this getSpillInstructionSize if it isn't returning a bool. Naming multi-purpose functions i always awkward :-)
Either:

`Optional<unsigned> getSpillInstruction(const TargetInstrInfo *TII) const;`

which makes the uses in AsmPrinter a bit odd.

Or one of
`bool  isSpillInstruction(const TargetInstrInfo *TII, unsigned &Size) const;`
`bool  isSpillInstruction(const TargetInstrInfo *TII, unsigned *Size = nullptr) const;`

which looks less elegant.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57271/new/

https://reviews.llvm.org/D57271