[PATCH] D57381: [CodeGen] Don't scavenge non-saved regs in exception throwing functions

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 29 09:04:48 PST 2019


efriedma added a comment.

LivePhysRegs had some related issues; see https://reviews.llvm.org/D42655 (and related discussion on https://reviews.llvm.org/D42509, which was reverted).  Can we structure this code the same way?



================
Comment at: lib/CodeGen/LiveRegUnits.cpp:128
   const MachineFunction &MF = *MBB.getParent();
   if (!MBB.succ_empty()) {
     addPristines(MF);
----------------
Please restructure this so we aren't checking succ_empty(); that check will cause wrong results in general.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57381/new/

https://reviews.llvm.org/D57381





More information about the llvm-commits mailing list