[PATCH] D52002: Omit range checks from jump tables when lowering switches with unreachable default
Bruno Ricci via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 29 07:18:44 PST 2019
riccibruno added a comment.
In D52002#1375417 <https://reviews.llvm.org/D52002#1375417>, @ayonam wrote:
> In D52002#1375416 <https://reviews.llvm.org/D52002#1375416>, @riccibruno wrote:
>
> > Thanks! In general I suggest watching the bots carefully, and aggressively revert to green if something goes wrong.
>
>
> Thanks. Actually this is my first checkin to any community software. Learning the ropes. Hope not to repeat in future.
Don't worry to much about it. Its just that once a bot is red it will not send additional notifications for new failures, which increase the chance that failures start adding up. I personally also do an asan+assert and a msan+assert build before pushing something, but its up to you if you want to do this (there are sanitizer bots which will catch it otherwise).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D52002/new/
https://reviews.llvm.org/D52002
More information about the llvm-commits
mailing list