[PATCH] D52002: Omit range checks from jump tables when lowering switches with unreachable default

Ayonam Ray via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 29 07:06:44 PST 2019


ayonam added a comment.

In D52002#1375411 <https://reviews.llvm.org/D52002#1375411>, @hans wrote:

> In D52002#1375393 <https://reviews.llvm.org/D52002#1375393>, @ayonam wrote:
>
> > In D52002#1375368 <https://reviews.llvm.org/D52002#1375368>, @riccibruno wrote:
> >
> > > Various tests are failing on the bots (http://lab.llvm.org:8011/one_line_per_build). For example: http://lab.llvm.org:8011/builders/clang-atom-d525-fedora-rel/builds/20256
> >
> >
> > I will revert the checkin, fix the tests and recheckin.
>
>
> Also please reference the review in the commit message when committing next time, by including this line: "Differential revision: https://reviews.llvm.org/D52002". That way the code review gets an update about the commit.


Thanks.  I added the line "Review ID: D52002 <https://reviews.llvm.org/D52002>".  Missed the "Differential revision" part.  Will take care from the next time.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52002/new/

https://reviews.llvm.org/D52002





More information about the llvm-commits mailing list