[PATCH] D41342: [InstCombine] Missed optimization in math expression: simplify calls exp functions

Dmitry Venikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 29 05:37:07 PST 2019


Quolyk marked 3 inline comments as done.
Quolyk added inline comments.


================
Comment at: test/Transforms/InstCombine/fmul-exp.ll:62
+;
+  %tmp = call fast double @llvm.exp.f64(double %a)
+  %tmp1 = call fast double @llvm.exp.f64(double %b)
----------------
spatel wrote:
> We don't need the full "fast" to enable these transforms. Can you adjust the tests to show the minimal amount of FMF necessary to allow the optimizations? We need "reassoc" + anything else?
> 
> Do you have commit access? If so, please commit these files to trunk with the current (without this code patch) output.
I have commit access, but I don't want to commit without patch approval. Revision is fixed according to your comments.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D41342/new/

https://reviews.llvm.org/D41342





More information about the llvm-commits mailing list