[PATCH] D57343: lit: Let lit.util.which() return a normcase()ed path

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 29 04:55:34 PST 2019


thakis added a comment.

In D57343#1374063 <https://reviews.llvm.org/D57343#1374063>, @zturner wrote:

> Shouldn't the hash be case-insensitive on windows?


I'm not sure: I think case-sensitive file systems on Windows are becoming more common with WSL. This seemed like the less intrusive change to me at least. If we make it case-insensitive on Win, we probably also want that on macOS, but there case-sensitive file systems also exist and are maybe more common, and it feels like a can of worms that I'd rather leave closed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57343/new/

https://reviews.llvm.org/D57343





More information about the llvm-commits mailing list