[PATCH] D57283: Recognize FreeBSD specific BFD names in OUTPUT_FORMAT

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

Please rebase.



================
Comment at: ELF/ScriptParser.cpp:396
 
-std::tuple<ELFKind, uint16_t, bool> ScriptParser::readBfdName() {
-  StringRef S = unquote(next());
+ScriptParser::BfdDesc ScriptParser::readBfdName() {
+  StringRef Name = unquote(next());
----------------
`readBfdName` was removed in r352407. (method was converted to a static helper)

So you can define `BfdDesc` in an anonymous namespace.


================
Comment at: ELF/ScriptParser.cpp:401
   if (S == "elf32-i386")
-    return std::make_tuple(ELF32LEKind, EM_386, false);
+    return BfdDesc(ELF32LEKind, EM_386, OSABI, false);
   if (S == "elf32-iamcu")
----------------
Then I think you can avoid adding a constructor in `BfdDesc` and can use:

`return {ELF32LEKind, EM_386, OSABI, false};`


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57283/new/

https://reviews.llvm.org/D57283