[PATCH] D57128: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib=

Kristina Brooks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 29 00:27:27 PST 2019


kristina added a comment.

In D57128#1375040 <https://reviews.llvm.org/D57128#1375040>, @mstorsjo wrote:

> FWIW, this also broke my bootstraps of mingw-w64 environments/toolchains. After building compiler-rt builtins, before having any libunwind/libcxx built, I previously regarded my toolchain as complete for building and testing C apps and libraries, but that fails now.
>
> Would it be possible to add a third alternative, `--unwindlib=none`, to signal that while I'm using `--rtlib=compiler-rt`, I don't want to link to any unwinder? (In my case, I'm injecting libunwind in libc++.a so it only gets added when linking C++ code.) Or at least make it possible to only add this linker flag when linking C++? Alternatively I'll need to provide a dummy `libunwind.a` until the real one has been built.


+1 on this, although consolidated libc++/libc++abi/libunwind_llvm have been supported "experimentally" for at least two years now, if this somehow breaks it, I think a lot of users would be frustrated.

(Also is it time to make merging libc++.a and libc++abi.a not-an-experimental (in CMake) feature anymore?).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57128/new/

https://reviews.llvm.org/D57128





More information about the llvm-commits mailing list