[PATCH] D53765: [RFC prototype] Implementation of asm-goto support in LLVM

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:2533
+
+  assert(isa<InlineAsm>(Callee) && "Only know how to handle inlineasm callbr");
+  visitInlineAsm(&I);
----------------
nickdesaulniers wrote:
> needs a `(void)Callee;` otherwise release builds produce:
> ```
> ../lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:2531:16: warning: unused variable 'Callee' [-Wunused-variable]
>   const Value *Callee(I.getCalledValue());
>                ^
> ```
> or can the whole expression just fit in the assert?
Still seeing this in Diff 183921.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53765/new/

https://reviews.llvm.org/D53765