[llvm] r352206 - Revert r351954 "Add a value_type to ArrayRef."

Mon Jan 28 23:50:02 PST 2019

Unfortunately nothing very specific: OOM on self-hosted armv8
buildbots (see below). Also see the discussion here:
http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20190121/621311.html

I'll try to include a better commit message in subsequent rollbacks :)

[1/3080] Building CXX object
lib/Demangle/CMakeFiles/LLVMDemangle.dir/MicrosoftDemangle.cpp.o
FAILED: lib/Demangle/CMakeFiles/LLVMDemangle.dir/MicrosoftDemangle.cpp.o
/home/buildslave/buildslave/clang-cmake-armv8-selfhost-neon/stage1.install/bin/clang++
  -DGTEST_HAS_RTTI=0 -D_DEBUG -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE
-D_LARGEFILE_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS
-D__STDC_LIMIT_MACROS -Ilib/Demangle
-I/home/buildslave/buildslave/clang-cmake-armv8-selfhost-neon/llvm/lib/Demangle
-I/usr/include/libxml2 -Iinclude
-I/home/buildslave/buildslave/clang-cmake-armv8-selfhost-neon/llvm/include
-mcpu=cortex-a57 -marm -fPIC -fvisibility-inlines-hidden
-Werror=date-time -Werror=unguarded-availability-new -std=c++11 -Wall
-Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual
-Wmissing-field-initializers -pedantic -Wno-long-long
-Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type
-Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion
-fdiagnostics-color -ffunction-sections -fdata-sections -O3
-UNDEBUG  -fno-exceptions -fno-rtti -MMD -MT
lib/Demangle/CMakeFiles/LLVMDemangle.dir/MicrosoftDemangle.cpp.o -MF
lib/Demangle/CMakeFiles/LLVMDemangle.dir/MicrosoftDemangle.cpp.o.d -o
lib/Demangle/CMakeFiles/LLVMDemangle.dir/MicrosoftDemangle.cpp.o -c
/home/buildslave/buildslave/clang-cmake-armv8-selfhost-neon/llvm/lib/Demangle/MicrosoftDemangle.cpp
LLVM ERROR: out of memory
Stack dump:
0.	Program arguments:
/home/buildslave/buildslave/clang-cmake-armv8-selfhost-neon/stage1.install/bin/clang-9
-cc1 -triple armv8-unknown-linux-gnueabihf -emit-obj -disable-free
-main-file-name MicrosoftDemangle.cpp -mrelocation-model pic
-pic-level 2 -mthread-model posix -mdisable-fp-elim -fmath-errno
-masm-verbose -mconstructor-aliases -fuse-init-array -target-cpu
cortex-a57 -target-feature +crc -target-feature +dsp -target-feature
-fp16fml -target-feature -ras -target-feature -dotprod -target-feature
+hwdiv-arm -target-feature +hwdiv -target-abi aapcs-linux -mfloat-abi
hard -fallow-half-arguments-and-returns -dwarf-column-info
-debugger-tuning=gdb -ffunction-sections -fdata-sections
-coverage-notes-file
/home/buildslave/buildslave/clang-cmake-armv8-selfhost-neon/stage2/lib/Demangle/CMakeFiles/LLVMDemangle.dir/MicrosoftDemangle.cpp.gcno
-resource-dir /home/buildslave/buildslave/clang-cmake-armv8-selfhost-neon/stage1.install/lib/clang/9.0.0
-dependency-file
lib/Demangle/CMakeFiles/LLVMDemangle.dir/MicrosoftDemangle.cpp.o.d -MT
lib/Demangle/CMakeFiles/LLVMDemangle.dir/MicrosoftDemangle.cpp.o -D
GTEST_HAS_RTTI=0 -D _DEBUG -D _FILE_OFFSET_BITS=64 -D _GNU_SOURCE -D
_LARGEFILE_SOURCE -D __STDC_CONSTANT_MACROS -D __STDC_FORMAT_MACROS -D
__STDC_LIMIT_MACROS -I lib/Demangle -I
/home/buildslave/buildslave/clang-cmake-armv8-selfhost-neon/llvm/lib/Demangle
-I /usr/include/libxml2 -I include -I
/home/buildslave/buildslave/clang-cmake-armv8-selfhost-neon/llvm/include
-U NDEBUG -internal-isystem
/usr/lib/gcc/arm-linux-gnueabihf/5.4.0/../../../../include/c++/5.4.0
-internal-isystem
/usr/lib/gcc/arm-linux-gnueabihf/5.4.0/../../../../include/arm-linux-gnueabihf/c++/5.4.0
-internal-isystem
/usr/lib/gcc/arm-linux-gnueabihf/5.4.0/../../../../include/arm-linux-gnueabihf/c++/5.4.0
-internal-isystem
/usr/lib/gcc/arm-linux-gnueabihf/5.4.0/../../../../include/c++/5.4.0/backward
-internal-isystem /usr/local/include -internal-isystem
/home/buildslave/buildslave/clang-cmake-armv8-selfhost-neon/stage1.install/lib/clang/9.0.0/include
-internal-externc-isystem /usr/include/arm-linux-gnueabihf
-internal-externc-isystem /include -internal-externc-isystem
/usr/include -O3 -Werror=date-time -Werror=unguarded-availability-new
-Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual
-Wmissing-field-initializers -Wno-long-long -Wimplicit-fallthrough
-Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor
-Wdelete-non-virtual-dtor -Wstring-conversion -pedantic -std=c++11
-fdeprecated-macro -fdebug-compilation-dir
/home/buildslave/buildslave/clang-cmake-armv8-selfhost-neon/stage2
-ferror-limit 19 -fmessage-length 0 -fvisibility-inlines-hidden
-fno-rtti -fno-signed-char -fobjc-runtime=gcc
-fdiagnostics-show-option -fcolor-diagnostics -vectorize-loops
-vectorize-slp -o
lib/Demangle/CMakeFiles/LLVMDemangle.dir/MicrosoftDemangle.cpp.o -x
c++ /home/buildslave/buildslave/clang-cmake-armv8-selfhost-neon/llvm/lib/Demangle/MicrosoftDemangle.cpp
-faddrsig
1.	/home/buildslave/buildslave/clang-cmake-armv8-selfhost-neon/llvm/lib/Demangle/MicrosoftDemangle.cpp:249:1:
current parser token 'SpecialTableSymbolNode'
2.	/home/buildslave/buildslave/clang-cmake-armv8-selfhost-neon/llvm/lib/Demangle/MicrosoftDemangle.cpp:242:23:
LLVM IR generation of declaration
'llvm::ms_demangle::Demangler::copyString'
3.	/home/buildslave/buildslave/clang-cmake-armv8-selfhost-neon/llvm/lib/Demangle/MicrosoftDemangle.cpp:242:23:
Generating code for declaration
'llvm::ms_demangle::Demangler::copyString'
clang-9: error: unable to execute command: Aborted (core dumped)
clang-9: error: clang frontend command failed due to signal (use -v to
see invocation)
clang version 9.0.0 (trunk 351966)
Target: armv8l-unknown-linux-gnueabihf
Thread model: posix
InstalledDir: /home/buildslave/buildslave/clang-cmake-armv8-selfhost-neon/stage1.install/bin
clang-9: note: diagnostic msg: PLEASE submit a bug report to
https://bugs.llvm.org/ and include the crash backtrace, preprocessed
source, and associated run script.
clang-9: note: diagnostic msg:
********************

On Mon, Jan 28, 2019 at 9:35 PM David Blaikie <dblaikie at gmail.com> wrote:

> how is it breaking? (quote of a compile failure or the like might be handy)
>
> On Fri, Jan 25, 2019 at 7:25 AM Clement Courbet via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>> Author: courbet
>> Date: Fri Jan 25 07:25:52 2019
>> New Revision: 352206
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=352206&view=rev
>> Log:
>> Revert r351954 "Add a value_type to ArrayRef."
>>
>> This breaks arm self-hosted buildbots.
>>
>> Modified:
>>     llvm/trunk/include/llvm/ADT/ArrayRef.h
>>     llvm/trunk/unittests/ADT/ArrayRefTest.cpp
>>
>> Modified: llvm/trunk/include/llvm/ADT/ArrayRef.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/ArrayRef.h?rev=352206&r1=352205&r2=352206&view=diff
>>
>> ==============================================================================
>> --- llvm/trunk/include/llvm/ADT/ArrayRef.h (original)
>> +++ llvm/trunk/include/llvm/ADT/ArrayRef.h Fri Jan 25 07:25:52 2019
>> @@ -44,7 +44,6 @@ namespace llvm {
>>      using const_iterator = const T *;
>>      using size_type = size_t;
>>      using reverse_iterator = std::reverse_iterator<iterator>;
>> -    using value_type = typename std::remove_cv<T>::type;
>>
>>    private:
>>      /// The start of the array, in an external buffer.
>>
>> Modified: llvm/trunk/unittests/ADT/ArrayRefTest.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ADT/ArrayRefTest.cpp?rev=352206&r1=352205&r2=352206&view=diff
>>
>> ==============================================================================
>> --- llvm/trunk/unittests/ADT/ArrayRefTest.cpp (original)
>> +++ llvm/trunk/unittests/ADT/ArrayRefTest.cpp Fri Jan 25 07:25:52 2019
>> @@ -51,14 +51,6 @@ static_assert(
>>      "Assigning from an initializer list");
>>  #endif
>>
>> -// Check Typedefs.
>> -static_assert(
>> -    std::is_same<ArrayRef<int>::value_type, int>::value,
>> -    "erroneous value_type");
>> -static_assert(
>> -    std::is_same<ArrayRef<const int>::value_type, int>::value,
>> -    "erroneous value_type");
>> -
>>  namespace {
>>
>>  TEST(ArrayRefTest, AllocatorCopy) {
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190129/8f380048/attachment-0001.html>