[PATCH] D57260: Check bool attribute value in getOptionalBoolLoopAttribute.
Michael Kruse via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 28 17:48:06 PST 2019
Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.
Thanks for catching this. Looks like I did not think about calling `getZExtValue` on ConstantInt, but didn't notive because ConstantInt* converts to bool implicitly.
It would be good if you could add the noise warning example as a test case.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57260/new/
https://reviews.llvm.org/D57260
More information about the llvm-commits
mailing list