[PATCH] D57302: [DAGCombine] More diamond carry pattern optimization.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 28 16:56:55 PST 2019


craig.topper added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:2522
+ *
+ * The end result is usualy an increase in operation required, but because the
+ * carry is now linarized, other tranforms can kick in and optimize the DAG.
----------------
usualy->usually


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:2523
+ * The end result is usualy an increase in operation required, but because the
+ * carry is now linarized, other tranforms can kick in and optimize the DAG.
+ *
----------------
linarized->linearized


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:2567
+
+  // We couldn't fnd a suitable Z.
+  if (!Z) return SDValue();
----------------
fnd->find


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57302/new/

https://reviews.llvm.org/D57302





More information about the llvm-commits mailing list