[PATCH] D57323: [WebAssembly] Enable main-function signature rewriting for WASI
Dan Gohman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 28 16:45:38 PST 2019
sunfish added a comment.
In D57323#1374682 <https://reviews.llvm.org/D57323#1374682>, @sbc100 wrote:
>
> But we already decided we wanted this behaviour and my change only got reverted because it was demoting the 3-arg form to the 2-arg form. Musl's crt0 currently expects the 2-arg form so this would align exactly with what you have done here: promote the 0-arg to 2-arg form but leave the 3-arg form (and all other forms) alone.
Ok, that works for me. And this way we can get rid of the wasm-temporary-workarounds flag completely, which is a nice bonus. Patch updated.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57323/new/
https://reviews.llvm.org/D57323
More information about the llvm-commits
mailing list