[PATCH] D57264: Bump minimum toolchain version

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast marked an inline comment as done.
hubert.reinterpretcast added inline comments.


================
Comment at: cmake/modules/CheckCompilerVersion.cmake:65
     if(NOT LLVM_NO_OLD_LIBSTDCXX)
       message(FATAL_ERROR "Host Clang must be able to find libstdc++4.8 or newer!")
     endif()
----------------
jfb wrote:
> hubert.reinterpretcast wrote:
> > libstdc++4.8 should also warn now, right?
> The comment above was pretty bad... Updated to use `__GLIBCXX__`.
Thanks for the fix!


================
Comment at: cmake/modules/CheckCompilerVersion.cmake:90
+      if(LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN)
+        message(WARNING "libstdc++ version should be at least ${GCC_SOFT_ERROR} because LLVM will soon use new C++ features which your toolchain version doesn't support.Ignoring because you've set LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN, but very soon your toolchain won't be supported.")
+      else()
----------------
Typo: "support.Ignoring".


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57264/new/

https://reviews.llvm.org/D57264