[PATCH] D57276: [WebAssembly] Expand BUILD_PAIR nodes

[Thomas Lively via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
tlively marked 3 inline comments as done.
Closed by commit rL352442: [WebAssembly] Expand BUILD_PAIR nodes (authored by tlively, committed by ).
Herald added a subscriber: llvm-commits.

Changed prior to commit:
  https://reviews.llvm.org/D57276?vs=183676&id=183973#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57276/new/

https://reviews.llvm.org/D57276

Files:
  llvm/trunk/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
  llvm/trunk/test/CodeGen/WebAssembly/simd-build-pair.ll


Index: llvm/trunk/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
===================================================================
--- llvm/trunk/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
+++ llvm/trunk/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
@@ -225,6 +225,9 @@
     }
   }
 
+  // Don't do anything clever with build_pairs
+  setOperationAction(ISD::BUILD_PAIR, MVT::i64, Expand);
+
   // Trap lowers to wasm unreachable
   setOperationAction(ISD::TRAP, MVT::Other, Legal);
 
Index: llvm/trunk/test/CodeGen/WebAssembly/simd-build-pair.ll
===================================================================
--- llvm/trunk/test/CodeGen/WebAssembly/simd-build-pair.ll
+++ llvm/trunk/test/CodeGen/WebAssembly/simd-build-pair.ll
@@ -0,0 +1,33 @@
+; RUN: llc < %s -asm-verbose=false -verify-machineinstrs -disable-wasm-fallthrough-return-opt -wasm-disable-explicit-locals -wasm-keep-registers -mattr=simd128 | FileCheck %s --check-prefixes CHECK
+
+target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128"
+target triple = "wasm32-unknown-unknown"
+
+; Test that BUILD_PAIR dag nodes are correctly lowered.
+; This code produces a selection DAG like the following:
+
+;    t0: ch = EntryToken
+;  t3: v4i32,ch = load<(load 16 from `<4 x i32>* undef`)> t0, undef:i32, undef:i32
+;        t30: i32 = extract_vector_elt t3, Constant:i32<2>
+;        t28: i32 = extract_vector_elt t3, Constant:i32<3>
+;      t24: i64 = build_pair t30, t28
+;    t8: ch = store<(store 8 into `i64* undef`, align 1)> t3:1, t24, undef:i32, undef:i32
+;  t9: ch = WebAssemblyISD::RETURN t8
+
+; CHECK:      i32x4.extract_lane
+; CHECK-NEXT: i64.extend_i32_u
+; CHECK-NEXT: i32x4.extract_lane
+; CHECK-NEXT: i64.extend_i32_u
+; CHECK-NEXT: i64.const {{.*}} 32
+; CHECK-NEXT: i64.shl
+; CHECK-NEXT: i64.or
+; CHECK-NEXT: i64.store
+define void @build_pair_i32s() {
+entry:
+  %0 = load <4 x i32>, <4 x i32>* undef, align 16
+  %shuffle.i184 = shufflevector <4 x i32> %0, <4 x i32> undef, <4 x i32> <i32 2, i32 3, i32 undef, i32 undef>
+  %bc357 = bitcast <4 x i32> %shuffle.i184 to <2 x i64>
+  %1 = extractelement <2 x i64> %bc357, i32 0
+  store i64 %1, i64* undef, align 1
+  ret void
+}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57276.183973.patch
Type: text/x-patch
Size: 2185 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190128/00173e43/attachment.bin>