[PATCH] D57198: [llvm-objcopy] Implement --set-section-flags.

Jake Ehrlich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 28 15:29:55 PST 2019


jakehehrlich added a comment.

In D57198#1370341 <https://reviews.llvm.org/D57198#1370341>, @rupprecht wrote:

> - Add --set-section-flags to the list of unimplemented COFF methods


Crap I guess we have to remember to do that for all new flags. I should have asked for this to be a white list instead of a black list. It doesn't make sense for ELF and eventually MachO to have to update flags when one or the other doesn't support this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57198/new/

https://reviews.llvm.org/D57198





More information about the llvm-commits mailing list