[PATCH] D57121: [ARM] Use sub for negative offset load/store in thumb1

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 28 15:29:54 PST 2019


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Target/ARM/ARMInstrThumb.td:190
 
+// t_addrmode_rr_sext := reg + reg
+//
----------------
Maybe add a brief comment here noting this is separate because we use different heuristics for ldrsb/ldrsh.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57121/new/

https://reviews.llvm.org/D57121





More information about the llvm-commits mailing list