[PATCH] D57277: [COFF, ARM64] Don't put jump table into a separate COFF section for EK_LabelDifference32

Mon Jan 28 15:03:16 PST 2019

TomTan marked an inline comment as done.
TomTan added inline comments.

================
Comment at: lib/Target/AArch64/AArch64AsmPrinter.cpp:583
   const TargetLoweringObjectFile &TLOF = getObjFileLowering();
-  MCSection *ReadOnlySec = TLOF.getSectionForJumpTable(MF->getFunction(), TM);
-  OutStreamer->SwitchSection(ReadOnlySec);
+  bool JTInDiffSection = !TLOF.shouldPutJumpTableInFunctionSection(
+      MJTI->getEntryKind() == MachineJumpTableInfo::EK_LabelDifference32,
----------------
efriedma wrote:
> I'm a little concerned that this is changing the behavior in more cases than you expect.  Do you have any idea if you're changing the behavior for MachO targets?
Yes, MachO target will also be changed. This is conservative change and should not break there. Or do you suggest checking Windows target here for JTInDiffSection?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57277/new/

https://reviews.llvm.org/D57277