[PATCH] D57304: [LLD] [MinGW] Ignore the --plugin and --plugin-opt options

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: MinGW/Options.td:71-74
+def plugin: S<"plugin">;
+def plugin_eq: J<"plugin=">, Alias<plugin>;
+def plugin_opt: S<"plugin-opt">;
+def plugin_opt_eq: J<"plugin-opt=">, Alias<plugin_opt>;
----------------
I prefer not to name options if they are ignored. I mean you can define these options as shown below

  def: S<"plugin">;
  def: J<"plugin=">;
  def: S<"plugin-opt">;
  def: J<"plugin-opt=">;

and that clearly conveys the intention that they are ignored, because you don't have a way to refer them.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57304/new/

https://reviews.llvm.org/D57304