[PATCH] D57323: [WebAssembly] Enable main-function signature rewriting for WASI

Mon Jan 28 14:44:38 PST 2019

sbc100 added a comment.

In D57323#1374475 <https://reviews.llvm.org/D57323#1374475>, @sunfish wrote:

> In D57323#1374325 <https://reviews.llvm.org/D57323#1374325>, @sbc100 wrote:
>
> > I tried to enable this by default recently but had to revert: https://reviews.llvm.org/D54117.
> >
> > I'm fine for this to land in the mean time but you might want to be aware of this issue.
>
>
> The patch here avoids the envp issue by limiting the transformation to the (standard-approved) `int main(void)` case, and not arbitrary signatures. So if it sees `int main(int argc, char *argv[], char *envp[])`, it won't do anything.

In that case can you just remove the TemporaryWorkarounds flag and always do this transform?  That is the behaviour we want and I only reverted my change because of the envp issue.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57323/new/

https://reviews.llvm.org/D57323