[lld] r352407 - Refactoring. NFC.

[Martin Storsjö via llvm-commits]

Yep, this fixed it for me. Thanks for the quick response!

On Mon, 28 Jan 2019, Rui Ueyama wrote:

> Hopefully fixed in r352435. I don't have GCC 5.4, but we already have very
> similar code in lld, so I believe the patch should fix the issue.
> 
> On Mon, Jan 28, 2019 at 1:39 PM Rui Ueyama <ruiu at google.com> wrote:
>       On it.
> 
> On Mon, Jan 28, 2019 at 12:49 PM Martin Storsjö <martin at martin.st>
> wrote:
>       On Mon, 28 Jan 2019, Rui Ueyama via llvm-commits wrote:
>
>       > Author: ruiu
>       > Date: Mon Jan 28 11:11:52 2019
>       > New Revision: 352407
>       >
>       > URL:
>       http://llvm.org/viewvc/llvm-project?rev=352407&view=rev
>       > Log:
>       > Refactoring. NFC.
>       >
>       > Modified:
>       >    lld/trunk/ELF/ScriptParser.cpp
>
>       This broke compilation with GCC 5.4:
>
>       ../tools/lld/ELF/ScriptParser.cpp: In function
>       ‘std::tuple<lld::elf::ELFKind, short unsigned int>
>       parseBfdName(llvm::StringRef)’:
>       ../tools/lld/ELF/ScriptParser.cpp:389:48: error:
>       converting to ‘std::tuple<lld::elf::ELFKind, short
>       unsigned int>’ from initializer list would use
>       explicit constructor ‘constexpr std::tuple<_T1,
>       _T2>::tuple(_U1&&, _U2&&) [with _U1 =
>       lld::elf::ELFKind; _U2 = llvm::ELF::<anonymous enum>;
>       <template-parameter-2-3> =
>       void;_T1 = lld::elf::ELFKind; _T2 = short unsigned int]’
>               .Case("elf32-i386", {ELF32LEKind, EM_386})
>                                                        ^
>
>       // Martin
> 
> 
>