[PATCH] D57198: [llvm-objcopy] Implement --set-section-flags.

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht marked an inline comment as done.
rupprecht added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/set-section-flags-and-rename.test:16
+    Flags:           [ ]
+    Content:        "c3c3c3c3"
+
----------------
jhenderson wrote:
> Nit: get rid of the content. It's not needed. Can you get rid of the Type and Flags fields too, or are they required?
This flag checking is done during argument parsing, so no section is needed at all.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/set-section-flags-multiple.test:16
+    Flags:           [ ]
+    Content:        "c3c3c3c3"
+  - Name:            .bar
----------------
jhenderson wrote:
> Ditto, here and below.
Removed content here, but I'd prefer to leave flags explicitly empty here (even though the test passes w/o it). Type is a required yaml field here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57198/new/

https://reviews.llvm.org/D57198