[PATCH] D56625: [LICM/MSSA] Add promotion to scalars by building an AliasSetTracker with MemorySSA.

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea marked 7 inline comments as done.
asbirlea added inline comments.


================
Comment at: include/llvm/Transforms/Utils/LoopUtils.h:152-156
+bool promoteLoopAccessesToScalars(
+    const SmallSetVector<Value *, 8> &, SmallVectorImpl<BasicBlock *> &,
+    SmallVectorImpl<Instruction *> &, SmallVectorImpl<MemoryAccess *> &,
+    PredIteratorCache &, LoopInfo *, DominatorTree *, const TargetLibraryInfo *,
+    Loop *, AliasSetTracker *, MemorySSAUpdater *, ICFLoopSafetyInfo *,
----------------
chandlerc wrote:
> Does `clang-format` only do this after your change? If not, I suspect either a weird configuration issue in your `clang-format` or it'd be nice to do the `clang-format` change first to make the diff more obvious here.
AFAICT it's because of adding the additional `MemorySSAUpdater *` argument.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56625/new/

https://reviews.llvm.org/D56625