[PATCH] D57338: gn build: Make cmake sync script work on Windows if git is a bat file

[Hans Wennborg via Phabricator via llvm-commits]

hans accepted this revision.
hans added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/utils/gn/build/sync_source_lists_from_cmake.py:22
+    gn_files = subprocess.check_output(['git', 'ls-files', '*BUILD.gn'],
+                                       shell=os.name == 'nt').splitlines()
 
----------------
Maybe worth a comment that shell=True is for the .bat file case?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57338/new/

https://reviews.llvm.org/D57338