[PATCH] D57342: gn build: Fix `lld-link: unknown flag: -fuse-ld=lld` warnings on Windows

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 28 11:20:55 PST 2019


thakis added a comment.

In D57342#1374050 <https://reviews.llvm.org/D57342#1374050>, @pcc wrote:

> LGTM
>
> (Hmm, where's lld-link coming from? Ah, http://llvm-cs.pcc.me.uk/utils/gn/build/toolchain/BUILD.gn#200 . Maybe that should be using use_lld?)


You mean like

  if (clang_base_path != "") {
    cl = "$clang_base_path/bin/clang-cl"
    if (use_lld) {
      link = "$clang_base_path/bin/lld-link"
    }
  }

?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57342/new/

https://reviews.llvm.org/D57342





More information about the llvm-commits mailing list