[PATCH] D57328: [DebugInfo][DAG] Always emit DBG_VALUEs of FrameIndexes regardless of their SDNodes

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

> We can create FrameIndex SDNodeDbgValue records even if the Value is never lowered to an SDNode in the current block.

That sounds awesome.

If a dbg.value pointing to a frame index and a dbg.value with a constant (both describing the same variable) appear in the same basic block, is the relative order between them lost?



================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:5326
+    if (const AllocaInst *AI = dyn_cast<AllocaInst>(V)) {
+      DenseMap<const AllocaInst *, int>::iterator SI =
+          FuncInfo.StaticAllocaMap.find(AI);
----------------
I'd probably use auto here.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57328/new/

https://reviews.llvm.org/D57328