[PATCH] D57139: GlobalISel: Fix creating MMOs with align 0

[Petar Avramovic via Phabricator via llvm-commits]

Petar.Avramovic added inline comments.


================
Comment at: lib/Target/Mips/MipsCallLowering.cpp:157
   MMO = MIRBuilder.getMF().getMachineMemOperand(MPO, MachineMemOperand::MOLoad,
-                                                Size, /* Alignment */ 0);
+                                                Size, /* Alignment */ 1);
 
----------------
Hi Matt. Could you use 
MinAlign(MIRBuilder.getMF().getSubtarget().getFrameLowering()->getStackAlignment(), Offset)
instead of 1 for alignment.


================
Comment at: lib/Target/Mips/MipsCallLowering.cpp:239
   MMO = MIRBuilder.getMF().getMachineMemOperand(MPO, MachineMemOperand::MOStore,
-                                                Size, /* Alignment */ 0);
+                                                Size, /* Alignment */ 1);
 
----------------
Same here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57139/new/

https://reviews.llvm.org/D57139